Add automatic versioning and required files #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JessicaS11 Please review and merge 😄 |
weiji14
reviewed
Feb 3, 2021
weiji14
reviewed
Feb 3, 2021
There was a problem hiding this comment.
Hopefully @JessicaS11 can have a look before merging. This PR looks pretty much ok to me aside from two minor comments. We should try and tag a v0.3.3 release soon after and get that icepyx conda package sorted at conda-forge/staged-recipes#13866!
Codecov Report
@@ Coverage Diff @@
## development #168 +/- ##
===============================================
+ Coverage 47.87% 47.92% +0.04%
===============================================
Files 17 17
Lines 1178 1179 +1
Branches 262 262
===============================================
+ Hits 564 565 +1
Misses 574 574
Partials 40 40
Continue to review full report at Codecov.
|
JessicaS11
approved these changes
Feb 4, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR add automatic versioning. This also adds requirements.txt as well as LICENSE file to source package since it's missing and causes conda-forge/staged-recipes#13866 to fail.